From e660d5937af1eb91d17a9a76375b15763ab26f50 Mon Sep 17 00:00:00 2001
From: 1e99 <noemail@noemail>
Date: Sat, 22 Mar 2025 14:31:17 +0100
Subject: [PATCH] cleanup code

---
 cron.go             | 66 ---------------------------------------------
 devices/devices.go  | 45 +++++++++++++++++++++++++++++++
 devices/libgpiod.go |  1 +
 main.go             |  5 ++--
 4 files changed, 48 insertions(+), 69 deletions(-)
 delete mode 100644 cron.go

diff --git a/cron.go b/cron.go
deleted file mode 100644
index 011e7e6..0000000
--- a/cron.go
+++ /dev/null
@@ -1,66 +0,0 @@
-package main
-
-import (
-	"log"
-	"time"
-
-	"git.1e99.eu/1e99/wolbodge/devices"
-	"git.1e99.eu/1e99/wolbodge/sessions"
-)
-
-func DeviceCheck(logger *log.Logger, device devices.Device, wantStatus func() (bool, error), exit <-chan bool) {
-	for {
-		select {
-		case <-exit:
-			break
-		default:
-			status, err := device.Status()
-			if err != nil {
-				logger.Printf("Failed to fetch device status, waiting 1 minute until next attempt: %s", err)
-				time.Sleep(1 * time.Minute)
-				continue
-			}
-
-			want, err := wantStatus()
-			if err != nil {
-				logger.Printf("Failed to fetch want status, waiting 1 minute until next attempt: %s", err)
-				time.Sleep(1 * time.Minute)
-				continue
-			}
-
-			if status == want {
-				// Don't lock up our single-threaded session storage too much
-				time.Sleep(2 * time.Second)
-				continue
-			}
-
-			err = device.PushPowerButton()
-			if err != nil {
-				logger.Printf("Failed to push power button, waiting 2 minutes until next attempt: %s", err)
-				// Cooldown to not overwhelm the device with start/stop requests
-				time.Sleep(2 * time.Minute)
-				return
-			}
-
-			logger.Printf("Pushed power button")
-			time.Sleep(2 * time.Minute)
-		}
-	}
-}
-
-func PruneStorage(logger *log.Logger, storage sessions.Storage, interval time.Duration, exit <-chan bool) {
-	for {
-		select {
-		case <-exit:
-			break
-		default:
-			/*pruned, err := storage.PruneTickets()
-			if err != nil {
-				logger.Printf("Failed to prune tickets: %s", err)
-			}
-
-			logger.Printf("Pruned %d tickets", pruned)
-			time.Sleep(interval)*/
-		}
-	}
-}
diff --git a/devices/devices.go b/devices/devices.go
index 19eeb91..c53aac0 100644
--- a/devices/devices.go
+++ b/devices/devices.go
@@ -1,6 +1,51 @@
 package devices
 
+import (
+	"log"
+	"time"
+)
+
 type Device interface {
 	Status() (bool, error)
 	PushPowerButton() error
 }
+
+func KeepDeviceInSync(logger *log.Logger, device Device, wantStatus func() (bool, error), exit <-chan bool) {
+	for {
+		select {
+		case <-exit:
+			break
+		default:
+			status, err := device.Status()
+			if err != nil {
+				logger.Printf("Failed to fetch device status, waiting 1 minute until next attempt: %s", err)
+				time.Sleep(1 * time.Minute)
+				continue
+			}
+
+			want, err := wantStatus()
+			if err != nil {
+				logger.Printf("Failed to fetch want status, waiting 1 minute until next attempt: %s", err)
+				time.Sleep(1 * time.Minute)
+				continue
+			}
+
+			if status == want {
+				// Don't lock up our single-threaded session storage too much
+				time.Sleep(2 * time.Second)
+				continue
+			}
+
+			err = device.PushPowerButton()
+			if err != nil {
+				logger.Printf("Failed to push power button, waiting 2 minutes until next attempt: %s", err)
+				// Cooldown to not overwhelm the device with start/stop requests
+				time.Sleep(2 * time.Minute)
+				return
+			}
+
+			logger.Printf("Pushed power button")
+			time.Sleep(2 * time.Minute)
+		}
+	}
+}
diff --git a/devices/libgpiod.go b/devices/libgpiod.go
index 428a71f..1295b92 100644
--- a/devices/libgpiod.go
+++ b/devices/libgpiod.go
@@ -8,6 +8,7 @@ import (
 )
 
 // TODO: Do not use subprocesses here, they are unreliable, provide hidden dependencies and are a common target for vulnerabilities.
+// TODO: Improve pulldown, pullup
 func NewLibgpiod(gpiochip string, powerButtonPin int, powerLEDPin int) Device {
 	device := &libgpiod{
 		gpiochip:       gpiochip,
diff --git a/main.go b/main.go
index f981330..2a0540e 100644
--- a/main.go
+++ b/main.go
@@ -5,8 +5,8 @@ import (
 	"html/template"
 	"log"
 	"net/http"
-	"time"
 
+	"git.1e99.eu/1e99/wolbodge/devices"
 	"git.1e99.eu/1e99/wolbodge/routes"
 
 	_ "embed"
@@ -46,8 +46,7 @@ func Run() error {
 	mux.Handle("DELETE /api/session/{session_id}", routes.APIEndSession(storage))
 
 	exit := make(chan bool)
-	go PruneStorage(logger, storage, 10*time.Second, exit)
-	go DeviceCheck(logger, device, storage.HasSessions, exit)
+	go devices.KeepDeviceInSync(logger, device, storage.HasSessions, exit)
 
 	logger.Printf("Listening on %s", address)
 	err = http.ListenAndServe(address, mux)